Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bots can now set activity state #6345

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Bots can now set activity state #6345

merged 3 commits into from
Aug 10, 2023

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Aug 9, 2023

turns out if you meme about something enough it actually can come true

image

image

@RedDaedalus RedDaedalus mentioned this pull request Aug 9, 2023
Merged
6 tasks
This was referenced Aug 9, 2023
Merged
Merged
@seailz
Copy link
Contributor

seailz commented Aug 9, 2023

dammit finally

@seailz seailz mentioned this pull request Aug 9, 2023
Closed
3 tasks
@MinnDevelopment
Copy link
Contributor

Can they also use emoji? Are there limitations to that?

@RedDaedalus
Copy link
Member

Can they also use emoji? Are there limitations to that?

emoji is not supported atm (https://canary.discord.com/channels/81384788765712384/381887113391505410/1138678286646509659)

@MinnDevelopment
Copy link
Contributor

Are there any plans to support emoji?

@advaith1
Copy link
Contributor Author

advaith1 commented Aug 9, 2023

I don't think so :(

@seailz seailz mentioned this pull request Aug 9, 2023
Merged
4 tasks
@Andre601
Copy link
Contributor

Andre601 commented Aug 9, 2023

I don't think so :(

It's time to get the memes back out again...

@sebm253 sebm253 mentioned this pull request Aug 9, 2023
Merged
@davfsa
Copy link
Contributor

davfsa commented Aug 9, 2023

This also needs updating:

discord-api-docs/docs/topics/Gateway_Events.md

Line 1023 in 0fa6238

| 4 | Custom | {emoji} {name} | ":smiley: I am cool" |

The current method seems incorrect, as the client seems to set name to "Custom Status" and and then use state for the message

@advaith1
Copy link
Contributor Author

advaith1 commented Aug 9, 2023

oh has that been wrong the whole time

streaming also shows name not details right? or does it use details and fall back to nane

@davfsa
Copy link
Contributor

davfsa commented Aug 9, 2023 •
edited
Loading

Streaming uses Streaming <name> and state is used to provide more information when opening up the full user (above with the Watch button). I didnt notice it is wrong too until now.

Another interesting behaviour I found is that it will fallback to Playing <name> if type is STREAMING (1) but no url is set.

@Dorukyum Dorukyum mentioned this pull request Aug 9, 2023
Closed
@nicolaeser
Copy link

Uhm Custom Status doesnt currently work for me

drillskibo
drillskibo reviewed Aug 9, 2023
View reviewed changes
Copy link

@drillskibo drillskibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we get what we wanted all along 🎉

tazz4843 added a commit to tazz4843/serenity that referenced this pull request Aug 9, 2023
@tazz4843
Add state field to Activity struct
fa75456 
Allows custom statuses to be used (see discord/discord-api-docs#6345)
@tazz4843 tazz4843 mentioned this pull request Aug 9, 2023
Merged
arqunis pushed a commit to serenity-rs/serenity that referenced this pull request Aug 9, 2023
@tazz4843
Add support for setting custom activity status (#2503)
4bb5d95 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
@DRSchlaubi DRSchlaubi mentioned this pull request Aug 9, 2023
Merged
@MinnDevelopment
Copy link
Contributor

Should probably also mention that you have to set a non-empty name in addition to state, since the status won't show up otherwise.

@Lulalaby
Copy link
Contributor

Lulalaby commented Aug 9, 2023

name should be set to Custom Status if we follow the client behavior

shaydewael
shaydewael requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@shaydewael shaydewael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes to the change log, but otherwise looks good. thanks (as always) 😄

docs/Change_Log.md Outdated Show resolved Hide resolved
docs/topics/Gateway_Events.md Outdated Show resolved Hide resolved
@advaith1 @shaydewael
wording changes
2ebeabd 
Co-authored-by: shay <[email protected]>
@PredaaA PredaaA mentioned this pull request Aug 9, 2023
Merged
@Misha-133 Misha-133 mentioned this pull request Aug 10, 2023
Merged
@i0bs i0bs mentioned this pull request Aug 10, 2023
Closed
1 task
@shaydewael shaydewael merged commit c3935ae into discord:main Aug 10, 2023
DonovanDMC added a commit to OceanicJS/Oceanic that referenced this pull request Aug 11, 2023
@DonovanDMC
Support custom statuses
ed954cd 
discord/discord-api-docs#6345
@advaith1 advaith1 deleted the custom-status-for-bots branch August 12, 2023 00:01
lukellmann added a commit to kordlib/kord that referenced this pull request Aug 23, 2023
@DRSchlaubi @lukellmann
Implement custom status (#857)
59d83d9 
See discord/discord-api-docs#6345

---------

Co-authored-by: lukellmann <[email protected]>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@tazz4843 @mkrasnitski
Add support for setting custom activity status (serenity-rs#2503)
0b7779b 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@tazz4843 @mkrasnitski
Add support for setting custom activity status (serenity-rs#2503)
c18215d 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@tazz4843 @mkrasnitski
Add support for setting custom activity status (serenity-rs#2503)
5334ed8 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@tazz4843 @arqunis
Add support for setting custom activity status (serenity-rs#2503)
9ffe3ed 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@tazz4843 @arqunis
Add support for setting custom activity status (serenity-rs#2503)
2281783 
This allows custom statuses to be used. See: discord/discord-api-docs#6345
@bsian03 bsian03 mentioned this pull request Jan 17, 2024
Open
55 tasks
@conorwastakenwastaken conorwastakenwastaken mentioned this pull request Jan 17, 2024
Merged
shaydewael added a commit to Jupith/discord-api-docs that referenced this pull request May 14, 2024
@advaith1 @shaydewael
Bots can now set activity state (discord#6345)
5935caf 
* Bots can now set activity state

* fix custom status format

* wording changes

Co-authored-by: shay <[email protected]>

---------

Co-authored-by: shay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drillskibo drillskibo drillskibo left review comments

@shaydewael shaydewael shaydewael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@advaith1 @seailz @MinnDevelopment @RedDaedalus @Andre601 @davfsa @nicolaeser @Lulalaby @shaydewael @drillskibo